Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically create the CloudFront ALIAS DNS record in Route 53 #249

Open
bugeats opened this issue May 29, 2019 · 1 comment
Open

Automatically create the CloudFront ALIAS DNS record in Route 53 #249

bugeats opened this issue May 29, 2019 · 1 comment

Comments

@bugeats
Copy link

bugeats commented May 29, 2019

Make sure you configure your DNS—add an ALIAS or CNAME from your domain to xxx.cloudfront.net

Why can't discharge to this itself? It has the desired domain name. All it needs to do is add a Route 53 record.

@brandonweiss
Copy link
Owner

Yeah, I thought about this at the time, let me see if I can remember my reasoning for not doing it…

The first question is, is this actually solving a problem? Right now someone needs to edit their DNS to point to S3/CloudFront after deploying for the first time. If I create the DNS entry for them in Route53… they still have to go into their registrar and point to Route53’s nameservers, so that doesn’t feel like much of a win.

There’s also a chance they already have DNS, in which case I wouldn’t want to force them to use Route53. I’d have to have to make Discharge more complicated and add steps for them to control whether or not it created DNS records for them and where.

If they did want to use Route53 for DNS, that creates another set of problems, which is what happens when they realize they need to add a DNS record for some reason? Let’s say to verify some Google service or something. Then they’d need to sign in to AWS and figure out how to use Route53. But the whole reason Discharge exists is to abstract away as much of AWS’s complexity as possible so you don’t have to get mired in it.

I think there might be a few other reasons I‘m forgetting now, but in sum, while I conceptually love the idea of automating as much as possible, I think a feature like this would add more complexity and potentially cause more problems than it’s worth, and it also might not be something most people want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants