Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long line wrapping jitter across "versions" #7

Closed
underrun opened this issue Jul 8, 2021 · 0 comments · Fixed by #8
Closed

Long line wrapping jitter across "versions" #7

underrun opened this issue Jul 8, 2021 · 0 comments · Fixed by #8

Comments

@underrun
Copy link
Contributor

underrun commented Jul 8, 2021 •
edited

i've used different commits of gojsontoyaml over the years. the behavior of wrapping long lines changes depending on when had go geted as follows:

  • Pre May 2020: long lines wrap
  • Between May 2020 and Dec 2020: long lines do not wrap
  • After Dec 2020: long lines wrap

... and to top that off, at some point in the future with yaml.v3 the default will again be the long lines will not wrap...

This is because of this fun: go-yaml/yaml#670 combined with the timing of updating the go mod for yaml.v2 in this repo (2.2.8 pre may, 2.3.0 may, 2.4.0 dec)

I'd love it if the line wrapping could shift back to the future of not doing it.
underrun added a commit to underrun/gojsontoyaml that referenced this issue Jul 8, 2021
@underrun
Adopt future go yaml line wrapping behavior
d659561 
Closes brancz#7

In v3, go yaml will not wrap lines by default: adopt this now to avoid
churn later and return to the previous default used in v2.3.0 which was
un-defaulted in v2.4.0 back to pre v2.3.0 behavior.
@underrun underrun mentioned this issue Jul 8, 2021
Merged
@brancz brancz closed this as completed in #8 Jul 9, 2021
@hasbro17 hasbro17 mentioned this issue Oct 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adopt future go yaml line wrapping behavior underrun/gojsontoyaml
1 participant
@underrun