Skip to content

Should sanitize-url replace zero width characters? #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jackw opened this issue Jun 1, 2021 · 3 comments
Closed

Should sanitize-url replace zero width characters? #35

jackw opened this issue Jun 1, 2021 · 3 comments

Comments

@jackw
Copy link

jackw commented Jun 1, 2021

Having updated to v5.0.1 I've noticed that sanitize-url is no longer replacing zero width characters.

Is this by design or a regression caused by changes made in v5.0.1?

Please see grafana/grafana#34528 for an example.
@crookedneighbor
Copy link
Contributor

Yeah, I believe that's a regression. We'll get it fixed.

@jackw
Copy link
Author

jackw commented Jun 1, 2021

Amazing! Thanks so much @crookedneighbor

@crookedneighbor
Copy link
Contributor

This is out in v5.0.2

@moul-bot moul-bot mentioned this issue Oct 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jackw @crookedneighbor