Snapshot filename special character scrub needed - semicolon #83
Comments
jf-tech
added a commit
to jf-tech/omniparser
that referenced
this issue
Sep 16, 2022
https://cs.opensource.google/go/x/mod/+/master:module/module.go;l=285;drc=02c991387e35f9e4c0a9b7ce137717055f8d716d so ";" is not allowed in the snapshot filename if the module needs to be imported. Filed a ticket against cupaloy: bradleyjkemp/cupaloy#83
jf-tech
added a commit
to jf-tech/omniparser
that referenced
this issue
Sep 16, 2022
https://cs.opensource.google/go/x/mod/+/master:module/module.go;l=285;drc=02c991387e35f9e4c0a9b7ce137717055f8d716d so ";" is not allowed in the snapshot filename if the module needs to be imported. Filed a ticket against cupaloy: bradleyjkemp/cupaloy#83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A recent commit jf-tech/omniparser@1b4997b introduced a snapshot filename containing
;. While itself is fine, i.e. running tests is all good, we ran into issues when the module being imported by 3rd party, hitting an error:Turns out
;isn't allowed in module filepath: https://cs.opensource.google/go/x/mod/+/master:module/module.go;l=285;drc=02c991387e35f9e4c0a9b7ce137717055f8d716dYour library already does many of the special character replacement during snapshot file creation. Wondering if
;semicolon can be added?Cheers!
The text was updated successfully, but these errors were encountered: