Add an option to disable usage of stringer methods. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilbsgilbs
changed the title
This is especially annoying for snapshotting custom errors that contain some payload. The payload would arbitrary be dismissed which is confusing. fixes bradleyjkemp#45
gilbsgilbs
force-pushed
the
use-stringer-methods
branch
from
4f373e7
to
ed8d087
Compare
|
Thanks for the really clear, well thought out and tested PR ❤️ Sorry this took so long to merge |
Apologies accepted. Just joking 😄 . Thank you for your work on this fantastic library and for reviewing my PR quite fast actually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially annoying for snapshotting custom errors that contain
some payload. The payload would arbitrary be dismissed which is
confusing.
fixes #45