Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-github to v43 #63

Merged
merged 1 commit into from Mar 2, 2022
Merged

Conversation

asvoboda
Copy link
Contributor

@asvoboda asvoboda commented Mar 2, 2022

No description provided.

@@ -1,12 +1,15 @@
github.com/bradleyfalzon/ghinstallation/v2 v2.0.4/go.mod h1:B40qPqJxWE0jDZgOR1JmaMy+4AY1eBP+IByOvqyAKp0=
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like google/go-github#2240 added ghinstallation as a dep on go-github

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just having a quick look, so we expect issues with this?

Edit, looks like they just bumped the version anyway, I’m not too concerned

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues, I'm just noting the implicit dependency getting picked up

Copy link
Collaborator

@wlynch wlynch Mar 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out!

Even though there's a circular module dependency, this should be fine so long as the ghinstallation and core go-github packages don't mix - because this in a separate examples package this is fine.

It is something to keep an eye on because this could cause some weird interactions with https://go.dev/ref/mod#minimal-version-selection picking more recent versions than intended, but as long as we maintain compatibility it's fine.
We can probably make some changes to completely prevent this though - we can either break the go-github examples into a new submodule (I'll open a PR for this), or worst case we can remove the dependency here if it does end up causing problems.

@asvoboda
Copy link
Contributor Author

asvoboda commented Mar 2, 2022

@bradleyfalzon / @wlynch do you mind taking a look?

@bradleyfalzon
Copy link
Owner

lgtm, I’ll tag in about 48 hours

@bradleyfalzon bradleyfalzon merged commit f6d76ac into bradleyfalzon:master Mar 2, 2022
@asvoboda asvoboda mentioned this pull request Mar 2, 2022
@asvoboda asvoboda deleted the as/update branch March 3, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants