Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor builder progress to animation #29

Closed
wants to merge 1 commit into from
Closed

refactor builder progress to animation #29

wants to merge 1 commit into from

Conversation

boyan01
Copy link
Owner

@boyan01 boyan01 commented Jan 27, 2020

close #28

typedef Widget AnimatedOverlayWidgetBuilder(BuildContext context, Animation<double> animation);

typedef Widget AnimatedOverlayRemovedWidgetBuilder(BuildContext context, Animation<double> animation);

@codecov
Copy link

codecov bot commented Jan 27, 2020

Codecov Report

Merging #29 into master will decrease coverage by 0.67%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #29      +/-   ##
=========================================
- Coverage   79.27%   78.6%   -0.68%     
=========================================
  Files           9       9              
  Lines         222     229       +7     
=========================================
+ Hits          176     180       +4     
- Misses         46      49       +3
Flag Coverage Δ
#unittests 78.6% <85.71%> (-0.68%) ⬇️
Impacted Files Coverage Δ
lib/src/toast/toast.dart 95.65% <100%> (+0.41%) ⬆️
lib/src/notification/overlay_notification.dart 100% <100%> (ø) ⬆️
lib/src/overlay.dart 82.6% <100%> (ø) ⬆️
lib/src/overlay_entry.dart 72.34% <100%> (ø) ⬆️
lib/src/notification/notification.dart 68.75% <100%> (+4.46%) ⬆️
lib/src/overlay_animation.dart 90% <62.5%> (-7.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 346b90c...7b0252e. Read the comment docs.

@boyan01 boyan01 mentioned this pull request May 23, 2020
Closed
@boyan01 boyan01 marked this pull request as draft June 27, 2020 02:13
@boyan01 boyan01 closed this Dec 15, 2020
@boyan01 boyan01 deleted the dev branch December 15, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should showOverlay() parameter builder be pass Animation instead of progress ?
1 participant
@boyan01