Added Dirac Distribution [Feature Request] #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dirac distribution is a trivial distribution but is useful for modelling certainty in situations. This implementation is fairly simple in that most outputs are either 0, 1, Infinity, or the point of the distribution.
boxtown
approved these changes
May 21, 2020
|
I just started off with the normal distribution as a base, so I kept the format/comments there while I modified the functions. I didn't know how to implement the inverse_cdf/pdf functions, but I hope that's fine. I noticed that I forgot to change some of the names in the documentation from normal, so I updated that. It should be good to go otherwise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I wanted to use this library in a small side-project that I was thinking about, and I noticed that it was missing the Dirac distribution, https://en.wikipedia.org/wiki/Dirac_delta_function#As_a_distribution, which would've been useful for my use case.
Please let me know if there's anything I can do to fix this PR up to meet your standards, or anything at all!
Thanks for all your work on the library!
I was also curious if you've ever explored using the quickcheck crate for property based testing, as it seems that some of the tests for distributions are testing some basic property and could be reduced?