Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download tar archives from https://github when possible #2263

Merged
merged 1 commit into from Nov 7, 2016
Merged

Conversation

sheerun
Copy link
Contributor

@sheerun sheerun commented Apr 21, 2016

This fixes #2247 as git checkout often fails on older git versions.

Additionally .tar.gz archives are downloaded for commits and branches.

@sheerun
Copy link
Contributor Author

sheerun commented Apr 21, 2016

@bower/contributors Please review and test

@ptitgraig
Copy link

Looking at it.

@benmann
Copy link
Member

benmann commented Apr 26, 2016

Even though I couldn't replicate the issue, the code still looks like the solution.
That said, not tested but still confident it will solve the issue. 🚢

@ptitgraig
Copy link

Sorry, taking time to understand. Not really at ease with bower architecture yet.

@sheerun
Copy link
Contributor Author

sheerun commented Jun 12, 2016

By the way, we need to make sure bower is working for old git versions (e.g. there is no blocking in interactive mode when repository doesn't exist..)

@doomedramen
Copy link
Member

For me it is pulling from https://github (instead of git://) with this change.

@doomedramen
Copy link
Member

doomedramen commented Jul 6, 2016

small point:
this is the longest running test, it may time out on some machines:
✓ should recognize git remote endpoints correctly (2012ms at worst) (ranged from 990ms - 2300ms)
✓ should recognize GitHub endpoints correctly (1722ms at worst) (ranged from 900ms to 1700ms)
(I tested on multiple machines and noted the time taken ranges above, the worst time was taken from a 3 year old macbook air)

@sheerun sheerun force-pushed the fix/github branch 2 times, most recently from be95ea8 to 39ed77a Compare November 7, 2016 00:38
This fixes #2247 as git checkout often fails on older git versions.

Additionally .tar.gz archives are downloaded for commits and branches.
@ankon
Copy link

ankon commented Nov 11, 2016

FWIW: This change nicely broke all our setups in Travis that had bower get stuff from private repositories. Previously we needed this configuration to make sure SSH authentication is used:

git config --global url.ssh://git@github.com/Collaborne/.insteadOf git://github.com/Collaborne/

With the change in resolvers we now have to fix all configurations to have redirects for both git:// and https://.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

bower install is stalling/hanging completely
5 participants