New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The "please choose one" dialogue should accept typing the version name as a way of indicating your choice #1714
Comments
Agree, got stuck with the same :) |
Please send a PR :) |
I just did the exact same thing and got stuck a few minutes searching for a possible bug or thinking the problem could be in the package. |
Added labels to indicate this is suitable for a beginner and is of low priority. |
Where will you make changes for this? A little help please. |
Instead of letting the user type version, shall we simply clarify the statement. |
@ptitgraig I'd honestly prefer that, especially because I think it is far more convenient to press one key instead of typing entire version numbers — I guess if we added the option and people knew about both possibilities, most would still just hit the number. Maybe even more important: it might prevent miss-typing the version more often. |
I agree with @benmann, if you show where to change the message in the source code, I can try here (I really want to contribute, even in such a small feature, to learn from it). |
How can I trigger this conflict message? I would like to do a PR of what @ptitgraig suggested. |
So if you're both interested we could actually do both — your choice :) If you want to go and implement the possibility to type the entire version you should have a look at To trigger this message you'd actually have to install a package that requires different versions of a certain package, or has dependencies that require different versions of a package. If the conflict cannot be resolved automatically (by choosing the higher version for example), the user is asked for input. |
I was about to send a PR but I will leave it to @echavezNS or @theaverageguy |
Thanks @thinkxl I just sent it. |
So part of this is implemented in #2212, but we can still implement the original idea behind the issue as well. If one of you is interested @thinkxl, @graciano or @theaverageguy just go for it. |
Hi @benmann, I came across this issue and decide to submit PR, I hope nobody was already assigned? :) |
@oskarcieslik I was thinking about doing it, but didn't have the time, so it's ok ;) |
Nice, thank you everybody! |
Hello everyone, I noticed this was closed but while using PowerShell on Windows 10 64 bit I did not even get to see the line numbers (there is nothing there but space and no, not even in yellow) and a Google search brought me here. I'm not sure if this should be a separate issue. |
@seyisulu Look, I'll especulate a little here and I could be wrong, but here it goes: |
This is amusingly petty, but...
Just now I ran a bower install and got this dialogue:
with the number at the beginning of each line (
1)
or2)
) highlighted in pink, the version spec (firebase#2.1.x
orfirebase#~2.2.1
) highlighted in blue, and the concrete version (2.1.2
or2.2.1
) highlighted in green.Because I am an idiot, I did not notice that the lines were numbered and tried typing the full version number or version spec as my answer instead, repeatedly getting told "Invalid choice!" as bower rejected my attempts to answer. I suspect, though I have no evidence, that others must have been caught out by this dialogue and made the same mistake. It took me a few minutes to figure out how to proceed.
Accepting the user typing in a full version spec, or, where unambiguous, a full version, seems like it would help silly people like me who don't think of typing the line number as their response.
The text was updated successfully, but these errors were encountered: