From 789622438461adce4d60a5fd94afec57f35b4884 Mon Sep 17 00:00:00 2001 From: GvS Date: Mon, 7 Nov 2016 00:27:14 +0000 Subject: [PATCH] Improve handling of non-semver versions in git resolver (#2316) --- lib/core/resolvers/GitResolver.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/core/resolvers/GitResolver.js b/lib/core/resolvers/GitResolver.js index 3c161a3f8..9f4917f60 100644 --- a/lib/core/resolvers/GitResolver.js +++ b/lib/core/resolvers/GitResolver.js @@ -206,7 +206,7 @@ GitResolver.prototype._savePkgMeta = function (meta) { version = semver.clean(this._resolution.tag); // Warn if the package meta version is different than the resolved one - if (typeof meta.version === 'string' && semver.neq(meta.version, version)) { + if (typeof meta.version === 'string' && semver.valid(meta.version) && semver.neq(meta.version, version)) { this._logger.warn('mismatch', 'Version declared in the json (' + meta.version + ') is different than the resolved one (' + version + ')', { resolution: this._resolution, pkgMeta: meta