From 19357166601cc2a587e04f1a05c4f4a3ea1aaf5d Mon Sep 17 00:00:00 2001 From: Max Schaefer Date: Wed, 28 Mar 2018 14:51:53 +0100 Subject: [PATCH] Fix issues found by lgtm (#2493) --- lib/commands/lookup.js | 2 +- lib/core/Manager.js | 2 -- lib/core/resolvers/GitResolver.js | 2 -- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/commands/lookup.js b/lib/commands/lookup.js index 5d095642c..9027836db 100644 --- a/lib/commands/lookup.js +++ b/lib/commands/lookup.js @@ -16,7 +16,7 @@ function lookup(logger, name, config) { .then(function (entry) { return !entry ? null : { name: name, - url: entry && entry.url + url: entry.url }; }); } diff --git a/lib/core/Manager.js b/lib/core/Manager.js index f1f9fcde4..ed66c4ba8 100644 --- a/lib/core/Manager.js +++ b/lib/core/Manager.js @@ -687,7 +687,6 @@ Manager.prototype._electSuitable = function (name, semvers, nonSemvers) { var unresolvable; var dataPicks; var save; - var choices; var picks = []; var versionRegex = /(?:[\d\w]\.){2}[\d\w](?:.)*/; var picksReleases; @@ -845,7 +844,6 @@ Manager.prototype._electSuitable = function (name, semvers, nonSemvers) { picks: dataPicks }); - choices = picks.map(function (pick, index) { return index + 1; }); picksReleases = picks.map(function (pick) { return pick.pkgMeta._release; }); return Q.nfcall(this._logger.prompt.bind(this._logger), { type: 'input', diff --git a/lib/core/resolvers/GitResolver.js b/lib/core/resolvers/GitResolver.js index b34a839a7..90d58c03a 100644 --- a/lib/core/resolvers/GitResolver.js +++ b/lib/core/resolvers/GitResolver.js @@ -121,8 +121,6 @@ GitResolver.prototype._findResolution = function (target) { version, index; - versionsArr = versions.map(function (obj) { return obj.version; }); - // If there are no tags and target is *, // fallback to the latest commit on master if (!versions.length && target === '*') {