You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should consider unpinning tokio in the tools workspace. Pinning tokio in bottlerocket makes sense given the level of confidence we want to have in bottlerocket's behavior. But for our publishing and builds tools, perhaps we don't need to be as strict.
In any event ~1.8 is incompatible with the new testsys CLI and blocks #2147 and #2148 (and the rest of cargo make test) because kube-rs has tokio = 1.14 in its Cargo.toml.
Note: I believe that getting us updated to 1.14 or better will require updating tough-ssm, tough-kms and coldsnap (because we stopped pinning tokio in those libs recently)
The text was updated successfully, but these errors were encountered:
It seems like tokio 1.14.x stops being supported this month (6/2022). I've started a discussion to see if there will be a new version dedicated as LTS: tokio-rs/tokio#4732
For the tools workspace I recommend that we use tokio = "1" and cargo update to latest in our lock file. I don't think we need to pin the tools workspace like we do for sources.
We should consider unpinning tokio in the tools workspace. Pinning tokio in bottlerocket makes sense given the level of confidence we want to have in bottlerocket's behavior. But for our publishing and builds tools, perhaps we don't need to be as strict.
In any event
~1.8
is incompatible with the newtestsys
CLI and blocks #2147 and #2148 (and the rest ofcargo make test
) because kube-rs hastokio = 1.14
in its Cargo.toml.Note: I believe that getting us updated to 1.14 or better will require updating tough-ssm, tough-kms and coldsnap (because we stopped pinning tokio in those libs recently)
The text was updated successfully, but these errors were encountered: