Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: unpin or update tokio #2153

Closed
webern opened this issue May 23, 2022 · 3 comments · Fixed by #2180
Closed

tools: unpin or update tokio #2153

webern opened this issue May 23, 2022 · 3 comments · Fixed by #2180
Assignees
Labels
area/testing Work relating to testing Bottlerocket type/bug Something isn't working
Milestone

Comments

@webern
Copy link
Member

webern commented May 23, 2022

We should consider unpinning tokio in the tools workspace. Pinning tokio in bottlerocket makes sense given the level of confidence we want to have in bottlerocket's behavior. But for our publishing and builds tools, perhaps we don't need to be as strict.

In any event ~1.8 is incompatible with the new testsys CLI and blocks #2147 and #2148 (and the rest of cargo make test) because kube-rs has tokio = 1.14 in its Cargo.toml.

Note: I believe that getting us updated to 1.14 or better will require updating tough-ssm, tough-kms and coldsnap (because we stopped pinning tokio in those libs recently)

@webern webern added type/bug Something isn't working dependencies area/testing Work relating to testing Bottlerocket labels May 23, 2022
@kdaula kdaula added this to the next milestone Jun 1, 2022
@cbgbt
Copy link
Contributor

cbgbt commented Jun 2, 2022

It seems like tokio 1.14.x stops being supported this month (6/2022). I've started a discussion to see if there will be a new version dedicated as LTS: tokio-rs/tokio#4732

@webern
Copy link
Member Author

webern commented Jun 2, 2022

For the tools workspace I recommend that we use tokio = "1" and cargo update to latest in our lock file. I don't think we need to pin the tools workspace like we do for sources.

@cbgbt
Copy link
Contributor

cbgbt commented Jun 2, 2022

I am definitely conflating issues which are actually tangential:

  • I agree that we don't need to pin the tools repo
  • We should move anything pinned to the 1.8 LTS release to the newest LTS, since 1.8 is no longer supported.

tokio has marked 1.18 as the next LTS in tokio-rs/tokio#4733, and plans to support that until January 2023.

@webern webern mentioned this issue Jun 6, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Work relating to testing Bottlerocket type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants