Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge bug fixes into release #1332

Open
NKID00 opened this issue Feb 10, 2021 · 2 comments
Open

Merge bug fixes into release #1332

NKID00 opened this issue Feb 10, 2021 · 2 comments

Comments

@NKID00
Copy link

NKID00 commented Feb 10, 2021

#1009 #1188 fixed the date formatting bug in the master branch. However the same bug still exists in the latest release and caused malfunction of my server.

master:

release-0.12:

  • bottle/bottle.py

    Lines 2499 to 2500 in 1522198

    lm = time.strftime("%a, %d %b %Y %H:%M:%S GMT", time.gmtime(stats.st_mtime))
    headers['Last-Modified'] = lm

  • bottle/bottle.py

    Line 2506 in 1522198

    headers['Date'] = time.strftime("%a, %d %b %Y %H:%M:%S GMT", time.gmtime())

  • bottle/bottle.py

    Line 1648 in 1522198

    value = time.strftime("%a, %d %b %Y %H:%M:%S GMT", value)

Is it possible to merge these bug fixes (and also other bug fixes which haven't been merged) into the release branch?

Or should I use the master branch in a production-grade server in order to get the bug fixed?

@oz123
Copy link
Contributor

oz123 commented Feb 10, 2021

@NKID00 I have been using the master branch for like 4 years now in production.. Never had a problem.
Bottle is quite well tested 💪

@NKID00
Copy link
Author

NKID00 commented Feb 10, 2021

@oz123 Thanks. The server using the master branch is working just fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants