Add set_exception for CRT Transfer future #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables more parity with the threaded, Python transfer manager where a subscriber can set an exception in the on_done callback such as failing to delete the source file after transfering it.
nateprewitt
approved these changes
Apr 20, 2021
Codecov Report
@@ Coverage Diff @@
## develop #195 +/- ##
===========================================
- Coverage 86.13% 86.01% -0.12%
===========================================
Files 16 16
Lines 2762 2767 +5
===========================================
+ Hits 2379 2380 +1
- Misses 383 387 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables more parity with the threaded, Python transfer manager where a subscriber can set an exception in the on_done
callback such as failing to delete the source file after transferring it.