Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ExpectedBucketOwner #192

Merged
merged 2 commits into from Apr 21, 2021
Merged

Add ExpectedBucketOwner #192

merged 2 commits into from Apr 21, 2021

Conversation

kdaily
Copy link
Member

@kdaily kdaily commented Apr 15, 2021 •
edited

Closes #181.

@kdaily kdaily requested a review from kyleknap April 16, 2021 17:03
@kyleknap kyleknap changed the title Test add ExpectedBucketOwner Add ExpectedBucketOwner Apr 21, 2021
kyleknap
kyleknap reviewed Apr 21, 2021
View reviewed changes
Copy link
Member

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I tried it out myself and looks like everything is plumbed through correctly. Thanks for tracking all of this down. I just had one really small comment and we can then merge it.

.changes/next-release/enhancement-s3-1285.json Outdated Show resolved Hide resolved
@kdaily kdaily mentioned this pull request Apr 21, 2021
Closed
@kdaily kdaily requested a review from kyleknap April 21, 2021 18:06
@kdaily
Copy link
Member Author

kdaily commented Apr 21, 2021

Also thanks to @liquidpele for starting this work!

kyleknap
kyleknap approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

@kyleknap kyleknap merged commit af982f8 into boto:develop Apr 21, 2021
@muralich2002
Copy link

Thank you so much @kdaily for getting this through!!!

@liquidpele
Copy link

Oh cool, thanks @kdaily for helping out and getting it merged.

@stobrien89 stobrien89 mentioned this pull request Feb 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleknap kyleknap kyleknap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include ExpectedBucketOwner to the Allowed List of upload arguments for multipart upload
4 participants
@kdaily @muralich2002 @liquidpele @kyleknap