Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask proxy url credentials #2543

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

zhan9san
Copy link
Contributor

Fix #2422

Could you kindly review this PR?

@zhan9san zhan9san force-pushed the feature/mask-proxy-credentials branch from 54dd040 to 9b3c284 Compare October 26, 2021 14:48
@kdaily kdaily added the needs-review This issue or pull request needs review from a core team member. label Nov 3, 2021
@jonchapmansai
Copy link

How do we get this reviewed?

@nateprewitt
Copy link
Contributor

Hi @zhan9san, thanks for the PR! We've added some minor changes and tests. We're working on doing final validation and will look to get this merged in an upcoming release.

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2022

Codecov Report

Merging #2543 (eaa4061) into develop (26528a5) will increase coverage by 0.11%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2543      +/-   ##
===========================================
+ Coverage    95.32%   95.43%   +0.11%     
===========================================
  Files           59       59              
  Lines        11474    11842     +368     
===========================================
+ Hits         10938    11302     +364     
- Misses         536      540       +4     
Impacted Files Coverage Δ
botocore/httpsession.py 91.35% <71.42%> (-0.54%) ⬇️
botocore/signers.py 98.17% <0.00%> (-0.46%) ⬇️
botocore/utils.py 95.64% <0.00%> (-0.07%) ⬇️
botocore/args.py 100.00% <0.00%> (ø)
botocore/config.py 100.00% <0.00%> (ø)
botocore/serialize.py 100.00% <0.00%> (ø)
botocore/docs/client.py 100.00% <0.00%> (ø)
botocore/parsers.py 99.45% <0.00%> (+<0.01%) ⬆️
botocore/credentials.py 98.66% <0.00%> (+0.01%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26528a5...eaa4061. Read the comment docs.

@nateprewitt nateprewitt merged commit 7409945 into boto:develop Jan 20, 2022
@jonchapmansai
Copy link

Thank you @zhan9san @nateprewitt @joguSD
I really appreciate your work improving that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review This issue or pull request needs review from a core team member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mask proxy credentials before raising exception
6 participants