Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtraArgs arguments supported by Bucket.copy #3163

Open
LeonidVas opened this issue Feb 22, 2022 · 1 comment · May be fixed by #3172
Open

ExtraArgs arguments supported by Bucket.copy #3163

LeonidVas opened this issue Feb 22, 2022 · 1 comment · May be fixed by #3172
Labels
bug This issue is a confirmed bug. documentation This is a problem with documentation. needs-review p3 This is a minor priority issue

Comments

@LeonidVas
Copy link

Hi! As far as I understood from https://github.com/boto/s3transfer/blob/279f82c6f9d01b19abf69d8fa08441c2064fba7f/s3transfer/manager.py#L381 the Bucket.copy operation should support ALLOWED_COPY_ARGS set of arguments in ExtraArgs (that is more than ALLOWED_UPLOAD_ARGS), but in the documentation and here describes that Bucket.copy supports only ALLOWED_DOWNLOAD_ARGS.

Which of the options is correct:

  • it is a mistake in the documentation and ALLOWED_COPY_ARGS support is guaranteed
  • a guaranteed set of arguments - only ALLOWED_DOWNLOAD_ARGS and it is not reasonable to use other arguments
  • I missed something when investigating the code and only the ALLOWED_DOWNLOAD_ARGS set of arguments is actually supported
@LeonidVas LeonidVas added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Feb 22, 2022
@LeonidVas LeonidVas mentioned this issue Feb 22, 2022
Merged
@kdaily kdaily added bug This issue is a confirmed bug. documentation This is a problem with documentation. and removed guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Feb 22, 2022
@kdaily kdaily self-assigned this Feb 22, 2022
@kdaily
Copy link
Member

kdaily commented Feb 22, 2022

Hi @LeonidVas,

Thanks for bringing this to our attention. This looks like a copy-paste error and the documentation should refer to ALLOWED_COPY_ARGS for the copy command.

@cibinmathew cibinmathew linked a pull request Mar 1, 2022 that will close this issue
Open
@aBurmeseDev aBurmeseDev added the p3 This is a minor priority issue label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a confirmed bug. documentation This is a problem with documentation. needs-review p3 This is a minor priority issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ExtraArgs supported by Bucket.copy cibinmathew/boto3
4 participants
@kdaily @aBurmeseDev @LeonidVas @tim-finnigan