Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 upload_file, download file do not support path-lib objects #2206

Closed
zhihaoy opened this issue Nov 15, 2019 · 9 comments
Closed

S3 upload_file, download file do not support path-lib objects #2206

zhihaoy opened this issue Nov 15, 2019 · 9 comments
Labels
feature-request This issue requests a feature.

Comments

@zhihaoy
Copy link

zhihaoy commented Nov 15, 2019

We should be able to use pathlib.Path in place of the local file string. Calling os.fspath would solve the issue.

@github-actions
Copy link

github-actions bot commented Dec 3, 2020

Greetings! It looks like this issue hasn’t been active in longer than one year. We encourage you to check if this is still an issue in the latest release. Because it has been longer than one year since the last update on this, and in the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment to prevent automatic closure, or if the issue is already closed, please feel free to reopen it.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Dec 3, 2020
@github-actions github-actions bot closed this as completed Dec 7, 2020
@alanyee
Copy link
Contributor

alanyee commented Jan 11, 2021

Can this ticket be reopened? The issue is still not resolved, and the PRs for the issue have not been reviewed.

@alanyee
Copy link
Contributor

alanyee commented Jan 11, 2021

@swetashre Just pinging for visibility

@swetashre
Copy link
Contributor

Reopening the issue as it has not been resolved.

@swetashre swetashre reopened this Jan 14, 2021
@github-actions
Copy link

Greetings! It looks like this issue hasn’t been active in longer than one year. We encourage you to check if this is still an issue in the latest release. In the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or upvote with a reaction on the initial post to prevent automatic closure. If the issue is already closed, please feel free to open a new one.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jan 14, 2022
@alanyee
Copy link
Contributor

alanyee commented Jan 15, 2022

I am still waiting for this #2259 to be reviewed and merged before closing this issue.

@github-actions github-actions bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jan 15, 2022
@marcmaxson
Copy link

3 years is a long time to wait for a simple feature overlooked by the boto3 devs to get fixed....

@aBurmeseDev aBurmeseDev added needs-review p2 This is a standard priority issue labels Nov 9, 2022
@alanyee
Copy link
Contributor

alanyee commented Dec 15, 2022

Having dealt with the problem itself, os.fspath does have an edge case with "file system representation of the path" may not match with how an object is uploaded and downloaded through AWS. os.path.normpath normalizes the case.

@jonemo
Copy link
Contributor

jonemo commented Dec 17, 2022

This was addressed in #2259 and released as part of version https://github.com/boto/boto3/releases/tag/1.26.32 today. Thanks to @alanyee for the contribution!

@jonemo jonemo closed this as completed Dec 17, 2022
@jonemo jonemo removed s3 needs-review p2 This is a standard priority issue labels Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request This issue requests a feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants