Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

should this use getbool rather than get? #3889

Open
mbmasuda opened this issue Oct 31, 2019 · 0 comments
Open

should this use getbool rather than get? #3889

mbmasuda opened this issue Oct 31, 2019 · 0 comments

Comments

@mbmasuda
Copy link

boto/boto/auth.py

Line 1062 in 8fac187

if boto.config.get('s3', 'use-sigv4', False):

I am wondering if this line should be changed to use getbool() rather than get(). It seems even if "use-sigv4" is set to "false", it tries to use SigV4 because "false" is a non-empty string and thus truthy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant