feat: price discovery offers dont need to have a 0 price #946
+1,676
−271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertfolch-redeemeum
changed the title
zajck
requested changes
May 22, 2024
There was a problem hiding this comment.
In addition to my comments in the code, can you please add a test, to see that commitToPriceDiscovery fails, if the actual price is below buyerCancelPenalty.
This must be tested for Bid, Ask and Wrapper side.
Please add them to test/protocol/PriceDiscoveryHandlerFacet.js
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
levalleux-ludo
approved these changes
May 24, 2024
albertfolch-redeemeum
deleted the
945-allow-non-zero-price-discovery-buyer-cancelation-for-price-discovery-offers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #945