Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment about approvals after voucher transfer #708

Open
thecryptofruit opened this issue Jul 6, 2023 · 0 comments
Open

Add comment about approvals after voucher transfer #708

thecryptofruit opened this issue Jul 6, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation v2.4.0

Comments

@thecryptofruit
Copy link
Member

WRT report 21520 about approvals remaining after voucher transfer, we might want to add in documentation that the protocol does not protect against compromised keys or compromised Seller Assistant. That could be secured by sellers using multi-sig or similar. Also could comment on approvals not being cleared on transfers, which IMO is standard practice.

@thecryptofruit thecryptofruit added the documentation Improvements or additions to documentation label Jul 6, 2023
@mischat mischat added the v2.4.0 label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation v2.4.0
Projects
None yet
Development

No branches or pull requests

2 participants