Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polluting buyer's and agent's available funds #679

Open
zajck opened this issue Jun 9, 2023 · 0 comments
Open

Polluting buyer's and agent's available funds #679

zajck opened this issue Jun 9, 2023 · 0 comments
Labels
wontfix This will not be worked on

Comments

@zajck
Copy link
Member

zajck commented Jun 9, 2023

#322 addresses the possibility to fill up the seller's available funds with unwanted tokens since anyone can deposit funds on the seller's behalf.

It's possible to do the same to buyers and agents as well.

To fill up the buyer's available funds, a malicious actor can act as a seller and:

  1. create an offer with an unwanted token and non-zero seller deposit;
  2. commit on the buyer's behalf
  3. revoke voucher, which releases unwanted token (seller deposit) to the buyer

To fill up the agent's available funds, a malicious actor can act as a seller and:

  1. create an offer with an unwanted token and assign the agent to the offer;
  2. commit to the offer;
  3. redeem the voucher;
  4. finalize the exchange, which releases the unwanted token (percentage of the price) to the agent
  • This fills up their available funds but does not send the (potentially malicious) token directly to the recipient. But the recipient can still withdraw it.
  • This does not affect the withdrawal of other buyer's or agent's funds
  • This pollutes getAvailableFunds with unwanted tokens
  • Dispute resolvers are not affected, since they can receive DR fees only in the exchange tokens they specify.
@mischat mischat added the wontfix This will not be worked on label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants