Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: "'requestAnimationFrame' called on an object that does not implement interface Window." #6508

Closed
xenolithviktor opened this issue Mar 18, 2021 · 3 comments
Closed

TypeError: "'requestAnimationFrame' called on an object that does not implement interface Window." #6508

xenolithviktor opened this issue Mar 18, 2021 · 3 comments
Labels
Status: Stale

Comments

@xenolithviktor
Copy link
Contributor

Describe the bug

TypeError: "'requestAnimationFrame' called on an object that does not implement interface Window."

The error occurs when running bootstrap-vue in the context of a WebExtension content script.

Steps to reproduce the bug

Use any bootstrap-vue component (for example <b-form-input>) that uses requestAF internally.

Expected behavior

The problem is that globalThis !== window in a WebExtension content script (see facebook/react#16606)
requestAF needs to be bound to Window so that this points to window.

Versions

Libraries:

  • BootstrapVue: 2.21.2
  • Bootstrap: 4.6.0
  • Vue: 2.6.11

Environment:

  • Device: PC
  • OS: Windows 10
  • Browser: Mozilla Firefox
  • Version: 86.0.1
xenolithviktor added a commit to xenolithviktor/bootstrap-vue that referenced this issue Mar 19, 2021
@xenolithviktor
fix(utils-dom): bind requestAD to WINDOW (bootstrap-vue#6508)
f93c0a8
xenolithviktor added a commit to xenolithviktor/bootstrap-vue that referenced this issue Mar 19, 2021
@xenolithviktor
fix(utils-dom): bind requestAF to WINDOW (bootstrap-vue#6508)
cb8b8bd
@xenolithviktor
Copy link
Contributor Author

Fixed it and did a pull request, see #6511

jacobmllr95 added a commit that referenced this issue May 4, 2021
@xenolithviktor @jacobmllr95
fix(utils/dom): bind requestAF() to window (#6508) (#6511)
f8caaec 
* fix(utils-dom): bind requestAF to WINDOW (#6508)

* Update dom.js

Co-authored-by: Jacob Müller <jacob.mueller.elz@gmail.com>
@stale
Copy link

stale bot commented Jun 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Status: Stale label Jun 18, 2021
@stale
Copy link

stale bot commented Jun 26, 2021

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@stale stale bot closed this as completed Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xenolithviktor