New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(b-dropdown): decrease delay when hiding inside a navbar on no-touch devices (closes #6306) #6367
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/2egyzrh46 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 23f1ec7:
|
Codecov Report
@@ Coverage Diff @@
## dev #6367 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 299 299
Lines 10105 10107 +2
Branches 2510 2510
=========================================
+ Hits 10105 10107 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks @andrei-gheorghiu! |
Describe the PR
Note: For avoiding a host of other problems on mobile devices related to the click/tap being delayed, the
300ms
delay when closing dropdowns is still present on any touch based devices. Consider it a technical limitation (or choosing the smaller evil).Related issues: #5982, #4328, #4344.
Closes #6306.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc.). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: