Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entering a quote with only a "On page" page number fails without an error #3364

Open
linkclau opened this issue Apr 28, 2024 · 4 comments
Open
Labels
bug Something isn't working

Comments

@linkclau
Copy link

linkclau commented Apr 28, 2024

Describe the bug
Entering a quote with only a "ON page" page number fails without an error (e.g. https://bookwyrm.social/book/1619541)

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://bookwyrm.social/book/1619541
  2. Select the "Quote" tab
  3. Enter a quote, a single "On page" page number and a comment (this is my mistake, if I enter the same number in "on page" and "o" it works)
  4. Click "Post" (I left the setting on public)
  5. No error is shown, I get back on the empty quote form

Expected behavior
I expect to get an error when posting without required data (and smart defaults, e.g. single page quote if only one page number is entered)

Screenshots
Filled out quote form
Screenshot from 2024-04-28 21-27-11
after clicking post I get here
Screenshot from 2024-04-28 21-36-45

Instance
On https://bookwyrm.social/user/realn2s

Additional context
Found the workaround to enter the same page in "On page" and "to". So it's just confusing but basically works
The error handling should be improved that I get a error message (and ideally the system also works if only one page number is entered).


Desktop (please complete the following information):
- OS: Linux/Ubuntu
- Browser: Firefox
- Version: 123.0.1

Smartphone (please complete the following information):
- Device: Android
- OS: 11
- Browser: Firefox
- Version: 125.2

@linkclau linkclau added the bug Something isn't working label Apr 28, 2024
@linkclau linkclau changed the title Quotes from a book are nowhere to be found Entering a quote with only a "On page" page number fails without an error Apr 28, 2024
@prolibre
Copy link

prolibre commented Apr 29, 2024

Duplicate :-)

#3352

Normally this has been fixed and will be included in the next update.

@gedankenstuecke
Copy link

I just wanted to say thanks for folks fixing (and reporting) this, I ran into the problem as well yesterday on https://bookwyrm.social and was glad to see that you're already ahead of it! ❤️

@dato
Copy link
Contributor

dato commented May 6, 2024 via email

@gedankenstuecke
Copy link

Thanks, that's good to know! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants