Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @bonfhir packages in Expo on Android devices #213

Open
nickvallee opened this issue Jan 10, 2024 · 2 comments
Open

Support @bonfhir packages in Expo on Android devices #213

nickvallee opened this issue Jan 10, 2024 · 2 comments
Assignees
Labels
bug Something isn't working not-likely-done-soon Very low chances of this getting it done soon react-native

Comments

@nickvallee
Copy link
Contributor

We are currently have an issue with loading bonfhir libraries on Android devices with the intent of using @bonfhir/gluestack-ui in Expo projects. In order to solve this issue, we need to discover how to make android compatible with one of the js engines.

Current error "Unexpected token '?'", without a stack trace.

What we know:

  • the issue comes when we set jsEngine to jsc in the app.json of an expo project.
  • using hermes is not possible. related issue Make @bonfhir/core compatible with react-native / hermes #139
  • the issue is present when on simulator and physical devices
  • bonfhir is es2022 and expo uses babel to transpile it to es5
  • error is not present on android using v8, but v8 is not compatible with @bonfhir/query at the moment.
unexpected_token
@nickvallee nickvallee added the bug Something isn't working label Jan 10, 2024
@julienblin
Copy link
Contributor

Funny thing - if I enable debug mode (by using Cmd+m), then the app is happy and it runs correctly. 😤

@julienblin julienblin self-assigned this Jan 16, 2024
@julienblin
Copy link
Contributor

Funny thing - if I enable debug mode (by using Cmd+m), then the app is happy and it runs correctly. 😤

This somewhat makes sense as I just learned than when debugging, the javascript then run in the chrome browser and not the app shell - and since bonfhir runs OK in Chrome, this makes sense. Not a good lead though, just confirming that jsc is not great on Android RN.

@julienblin julienblin removed their assignment Jan 16, 2024
@julienblin julienblin added not-likely-done-soon Very low chances of this getting it done soon react-native labels Jan 16, 2024
@opiation opiation self-assigned this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working not-likely-done-soon Very low chances of this getting it done soon react-native
Projects
None yet
Development

No branches or pull requests

3 participants