Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggering a 404 on a site in maintenance mode displays a page template #7813

Open
ankedsgn opened this issue Oct 21, 2019 · 4 comments
Open
Labels

Comments

@ankedsgn
Copy link

Hi,
We use the maintenance_mode: true often to block a site from visibility from the public, e.g. when it's still under development.

Up until recently i didn't notice, but if you have a maintenance site, and you trigger a 404 (examplesite.org/hfhfhf) you see the 404 template, instead of the maintenance notice.
I would expect the maintenance mode to block any views to any pages whatsoever, but probably, since the 404 routing is different, you see the 404 template instead.

Steps to reproduce

  • Set site config to maintenance_mode: true
  • Refresh homepage -> you get the maintenance notice
  • Trigger a 404 -> you get the 404 template

Expected result

  • Triggering the 404 would still show me the maintenance notice

Thanks for listening!

@stale
Copy link

stale bot commented Dec 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. Maybe this issue has been fixed in a recent release, or perhaps it is not affecting a lot of people?
It will be closed if no further activity occurs, because we like to keep the issue queue concise and actual.
If you think this issue is still relevant, please let us know. Especially if you’d like to help resolve the issue, either by helping us pinpointing the cause of a bug, or in implementing a fix or new feature.

@stale stale bot added the stale Stale issues & PRs flagged for closing label Dec 20, 2019
@ankedsgn
Copy link
Author

No Stalebot, this is a real issue, that should be solved! :)

@stale stale bot removed the stale Stale issues & PRs flagged for closing label Dec 20, 2019
@stale
Copy link

stale bot commented Feb 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. Maybe this issue has been fixed in a recent release, or perhaps it is not affecting a lot of people?
It will be closed if no further activity occurs, because we like to keep the issue queue concise and actual.
If you think this issue is still relevant, please let us know. Especially if you’d like to help resolve the issue, either by helping us pinpointing the cause of a bug, or in implementing a fix or new feature.

@stale stale bot added the stale Stale issues & PRs flagged for closing label Feb 18, 2020
@ankedsgn
Copy link
Author

not fixed, not stale! :)

@stale stale bot removed the stale Stale issues & PRs flagged for closing label Feb 19, 2020
@SahAssar SahAssar added the keep label Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants