Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Extensions with package.json should fetch exact version from CDN #11380

Closed
philippjfr opened this issue Jun 24, 2021 · 1 comment · Fixed by #11387
Closed

[BUG] Extensions with package.json should fetch exact version from CDN #11380

philippjfr opened this issue Jun 24, 2021 · 1 comment · Fixed by #11387

Comments

@philippjfr
Copy link
Contributor

Currently pre-built extensions with a package.json generate a CDN URL using:

cdn_url = f"{_default_cdn_host}/{pkg_name}@^{pkg_version}/{pkg_main}"

While following semver makes might be a technically justifiable position it can cause very hard to debug issues because the caret (^) means that NPM will fetch any “Compatible with version”, i.e. all minor/patch versions, without incrementing the major version. ^2.3.4 will use releases from 2.3.4 to <3.0.0. Since almost no library actually follows semver this means that even though you might have installed Panel 0.11.3 in Python it will still fetch panel.js 0.12.0 from CDN.

Therefore I would strongly suggest that it specifies the exactly matching version from CDN.

@bryevdv
Copy link
Member

bryevdv commented Jun 24, 2021

Therefore I would strongly suggest that it specifies the exactly matching version from CDN.

For extensions I agree 100%. I suppose we could make it configurable but default to exact versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants