Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websocket local origin: use port returned by bind_sockets #10178

Merged
merged 1 commit into from Jun 16, 2020
Merged

Websocket local origin: use port returned by bind_sockets #10178

merged 1 commit into from Jun 16, 2020

Conversation

xavArtley
Copy link
Contributor

@bryevdv
Copy link
Member

bryevdv commented Jun 16, 2020

Thanks @xavArtley we are planning to release follow on 2.1.1 early next week.

@bryevdv bryevdv merged commit bd947ea into master Jun 16, 2020
@bryevdv bryevdv deleted the xav/serve_port_0 branch June 16, 2020 16:18
@mattpap
Copy link
Contributor

mattpap commented Jun 17, 2020

This will have to be cherry picked into release-2.1 branch.

bryevdv pushed a commit that referenced this pull request Jun 18, 2020
@xavArtley @bryevdv
Websocket origin use port returned by bind_sockets (#10178)
6172cda
@bryevdv
Copy link
Member

bryevdv commented Jun 18, 2020

This will have to be cherry picked into release-2.1 branch.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryevdv bryevdv bryevdv approved these changes

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Serve application at random port failed
3 participants
@xavArtley @bryevdv @mattpap