Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When metadata is "preseeded" (constant per request), ghz adds repeated grpc-accept-encoding=gzip headers #441

Closed
TheSafo opened this issue May 21, 2024 · 1 comment

Comments

@TheSafo
Copy link

TheSafo commented May 21, 2024

Describe the bug
When metadata is "preseeded" (constant per request), ghz adds repeated grpc-accept-encoding=gzip headers (each request keeps appending to the same object so it's duplicated 1000s of times).

To Reproduce
ghz--metadata='{"my-header":"my-value"}' --call <request> -B <data> <url> --enable-compression

Expected behavior
grpc-accept-encoding=gzip is set a single time on the metadata.

Environment

  • OS:
  • ghz: v0.118.0

Additional context
I believe this https://github.com/bojand/ghz/blob/master/runner/worker.go#L99-L101 is the problematic line - when the MD object is shared accross all requests it infinitely appends to the same object.

@bojand bojand closed this as completed in ce5446b May 30, 2024
bojand added a commit that referenced this issue May 30, 2024
fix: user metadata set to set grpc-accept-encoding to fix #441
@bojand
Copy link
Owner

bojand commented May 30, 2024

Oof. I think this should be fixed with #444 and available in 0.120.0. Feel free to reopen with more info if this doesn't fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants