Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build on x86 without SSE2 due to outdated quanta dep #178

Closed
wez opened this issue Apr 8, 2023 · 2 comments · Fixed by #175
Closed

Fails to build on x86 without SSE2 due to outdated quanta dep #178

wez opened this issue Apr 8, 2023 · 2 comments · Fixed by #175

Comments

@wez
Copy link

wez commented Apr 8, 2023

This is the underlying issue:

surfaces over in:

Please consider updating to a current version of quanta

@antifuchs
Copy link
Collaborator

Known bug (#174), addressed in #175, which unfortunately is not straightforward: There's a 50% perf regression in our quanta-based benchmarks that I haven't been able to track down yet.

If you want to quickly fix this, pull in governor without default features & leave out the quanta feature; that should compile it with std::time::Instant as the default clock.

Separately, I'm surprised: is this crate working on x86? I thought due to the use of AtomicU64 in #89, this crate doesn't work on non-64bit platforms.

@wez
Copy link
Author

wez commented Apr 9, 2023

Thanks; I already found that I can omit the quanta feature.

re: 32-bit systems, I don't know how/if it works. I was passing on a build failure from @kekePower who is packaging wezterm for the Mageia distribution. Apparently with quanta removed (only the std feature enabled) it compiles, so it should work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants