Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector::chunks is misleading #50

Closed
vi opened this issue Oct 19, 2018 · 2 comments
Closed

Vector::chunks is misleading #50

vi opened this issue Oct 19, 2018 · 2 comments
Labels
breaking Breaking change, needs major bump

Comments

@vi
Copy link

vi commented Oct 19, 2018

I expected to see Vec::chunks and Vec::chunks_exact, but for Vector; but for im's vector chunks mean something different.

Maybe Vector::chunks and Vector::chunks_mut should be renamed somehow?

@vi vi changed the title chunks is misleading Vector::chunks is misleading Oct 19, 2018
@bodil
Copy link
Owner

bodil commented Oct 24, 2018

I agree, but this would mean a breaking change and it isn't something dramatic enough that I'm prepared to make a major release for it on its own, so I think I'm going to leave it as is for now and fix it along with the next major bump.

@bodil bodil added the breaking Breaking change, needs major bump label Oct 24, 2018
@vi
Copy link
Author

vi commented Oct 24, 2018

breaking change

As usual, deprecate & provide renamed alternative now, replace chunks with actual std-equivalient chunks later, after breaking release.

bodil added a commit that referenced this issue Oct 25, 2018
@bodil bodil closed this as completed in fdc7394 Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change, needs major bump
Projects
None yet
Development

No branches or pull requests

2 participants