Avoid using trim() on null #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
force-pushed
the
fix/trim-php-8.1
branch
from
2713e40
to
d5499fc
Compare
schlessera
force-pushed
the
fix/trim-php-8.1
branch
from
1857e8a
to
10a6c7c
Compare
|
Trying to run the tests produces errors of missing files for me: Maybe I'm missing something...? |
|
Awesome, thanks! Yes, the spec test uses a suuuuper old version of the Symfony YAML parser that doesn't exist in Composer so it's installed via git submodules 😬 Confirmed locally, I'll merge. |
|
Great, thanks! May I ask if there is a release scheduled for PHP 8.1 compatibility? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$delimitersargument for theTokenizer::scan()method is optional and currently defaults tonull(which is not documented as a valid value in the docblock'.This default value of
nullis then passed into thetrim()function, which causes a deprecation warning starting with PHP 8.1:This PR changes the default value to be an empty string instead, which makes the deprecation warning go away in most cases without any further changes and is more corrected in terms o the documented argument type.
Furthermore, the PR adds a check to see if the
$delimitersare a string before trying to trim them.Finally, a few tests are added to ensure custom delimiter handling works as expected.