Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control Click Opens Popup rather than goining to definition #441

Closed
maheshkurmi opened this issue Mar 16, 2022 · 5 comments
Closed

Control Click Opens Popup rather than goining to definition #441

maheshkurmi opened this issue Mar 16, 2022 · 5 comments
Assignees
Labels
Milestone

Comments

@maheshkurmi
Copy link

I am using RSyntaxTexArea with "js" language support. Prior to version 3.1 Ctrl + Click on any variable moved cursor to its definition, but in 3.2.0 Ctrl+Click opens defualt popmenu (cur, copy paste etc menu). Is it intentional or a bug?

I am using eclipse on Mac (Note: Command+Click does nothing)

@bobbylight
Copy link
Owner

Interesting, I can't reproduce it on Windows, at least not with the latest build of RSTALanguageSupport (running its DemoApp). I'll try on a mac tomorrow.

Is the only change you made updating RSTA to 3.2.0? What version of RSTALanguageSupport are you using?

And no - that behavior would not be intentional :)

@bobbylight
Copy link
Owner

On a Mac I see ctrl+click opening the popup menu and navigarting to/selecting the definition. I'll admit I haven't used this funcdtionality on a Mac in quite a while, so I don't know when this behavior changed. I'll look back to pre-3.1.0 releases and ses what's changed.

@maheshkurmi
Copy link
Author

maheshkurmi commented Mar 21, 2022

It was working fine in 3.0.0 version on Mac. On 3.2.0 version when I ctrl+click it goes to definition but still shows popup.
One more issue on version 3.2.0, I have to add HyperlinkListener to the editor in order to make go to definition work. If no hyperlink listener is set it does nothing on mac and windows both, it just opens popup without navigating to definition.

@bobbylight
Copy link
Owner

One more issue on version 3.2.0, I have to add HyperlinkListener to the editor in order to make go to definition work. If no hyperlink listener is set it does nothing on mac and windows both, it just opens popup without navigating to definition.

Just a note that this particular bit was fixed in the fix for #443. The Mac-specific popup issue is still there.

@bobbylight
Copy link
Owner

This was fixed by changing the default hyperlink mask on Macs from ctrl to cmd. This is more natural anyway. It fixes things by avoiding a collision with another standard Mac shortcut, ctrl + click to open the context menu.

@bobbylight bobbylight self-assigned this Sep 25, 2022
@bobbylight bobbylight added this to the 3.2.1 milestone Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants