Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blocklist - Don't display the current theme's template variations #54

Open
bobbingwide opened this issue Sep 16, 2022 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Sep 16, 2022

In Gutenberg 13.8.0 the oik-block/blocklist block displayed a whole load of new variations for the core/template-part block.

  • These are not insertable in the Block editor.
  • They are also unique for the current theme.
  • therefore, in my opinion, they should not be listed in the oik-block/blocklist set of blocks.

Requirement

  • The oik-block/blocklist block should not display theme specific variations of the core/template-part block.

Proposed solution

  • For the core/template-part block type filter out variations which have attributes.theme set
  • This logic is also needed when displaying variations in the blockinfo block.
@bobbingwide
Copy link
Owner Author

The filtering logic needs to be the same for both the block list and the block info block.
In the first attempt the logic was duplicated but only checked the block type for the block list.
Consequently, variations for the Query Title block weren't being shown.

bobbingwide added a commit that referenced this issue Nov 1, 2022
bobbingwide added a commit that referenced this issue Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant