Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled Python publish #691

Open
lord-haffi opened this issue Jan 12, 2024 · 0 comments
Open

Scheduled Python publish #691

lord-haffi opened this issue Jan 12, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code

Comments

@lord-haffi
Copy link
Collaborator

Currently, the scheduled github action creates a git tag and pushes it to origin. Additionally, it does the same as the normal python-publish workflow (code is copy pasted). This is needed atm, because such a git tag is not a GitHub release. Therefore, the python-publish workflow would not be triggered.

It would be better to use the GitHub API to only create a full GitHub release. In this case GitHub would automatically trigger the existent python-publish workflow and we wouldn't need to have duplicate code in these actions.
An example of how you can create a release via the GitHub API is in the python-publish workflow where we push the new JSON-schemas.

def create_release(

@lord-haffi lord-haffi added bug Something isn't working Python Specific 🐍 a problem that is specific to this python implementation and not the bo4e data model labels Jan 12, 2024
@lord-haffi lord-haffi added enhancement New feature or request github_actions Pull requests that update GitHub Actions code and removed bug Something isn't working Python Specific 🐍 a problem that is specific to this python implementation and not the bo4e data model labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

No branches or pull requests

2 participants