Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort-hook fails with python3.11 #528

Closed
mj0nez opened this issue Sep 20, 2023 · 0 comments · Fixed by #529
Closed

isort-hook fails with python3.11 #528

mj0nez opened this issue Sep 20, 2023 · 0 comments · Fixed by #529
Labels
bug Something isn't working Python Specific 🐍 a problem that is specific to this python implementation and not the bo4e data model

Comments

@mj0nez
Copy link
Contributor

mj0nez commented Sep 20, 2023

Running the current pre-commit config with python 3.11 fails because of an unpinned version of poetry in isort see: issue#2078 and PR

Steps To Reproduce

tox -r -e dev -x testenv:dev.basepython=python3.11
source .tox/dev/bin/activate  
pre-commit run

Expected vs. Actual Behavior

What you expected

Allow development with python >=3.10

What actually happened

Creating a commit fails with:

❯ pre-commit run
[WARNING] Unstaged files detected.
[INFO] Stashing unstaged files to /home/marcel/.cache/pre-commit/patch1695227048-122975.
[INFO] Installing environment for https://github.com/pycqa/isort.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Restored changes from /home/marcel/.cache/pre-commit/patch1695227048-122975.
An unexpected error has occurred: CalledProcessError: command: ('/home/marcel/.cache/pre-commit/repoptdaaa06/py_env-python3/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
    Processing /home/marcel/.cache/pre-commit/repoptdaaa06
      Installing build dependencies: started
      Installing build dependencies: finished with status 'done'
      Getting requirements to build wheel: started
      Getting requirements to build wheel: finished with status 'done'
      Preparing metadata (pyproject.toml): started
      Preparing metadata (pyproject.toml): finished with status 'error'
stderr:
      error: subprocess-exited-with-error
      
      × Preparing metadata (pyproject.toml) did not run successfully.
      │ exit code: 1
      ╰─> [17 lines of output]
          Traceback (most recent call last):
            File "/home/marcel/.cache/pre-commit/repoptdaaa06/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
              main()
            File "/home/marcel/.cache/pre-commit/repoptdaaa06/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
              json_out['return_val'] = hook(**hook_input['kwargs'])
                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            File "/home/marcel/.cache/pre-commit/repoptdaaa06/py_env-python3/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
              return hook(metadata_directory, config_settings)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            File "/tmp/pip-build-env-2xs_kss9/overlay/lib/python3.11/site-packages/poetry/core/masonry/api.py", line 41, in prepare_metadata_for_build_wheel
              poetry = Factory().create_poetry(Path(".").resolve(), with_groups=False)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            File "/tmp/pip-build-env-2xs_kss9/overlay/lib/python3.11/site-packages/poetry/core/factory.py", line 58, in create_poetry
              raise RuntimeError("The Poetry configuration is invalid:\n" + message)
          RuntimeError: The Poetry configuration is invalid:
            - [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'
          
          [end of output]
      
      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: metadata-generation-failed
    
    × Encountered error while generating package metadata.
    ╰─> See above for output.
    
    note: This is an issue with the package mentioned above, not pip.
    hint: See above for details.
Check the log at /home/marcel/.cache/pre-commit/pre-commit.log

Additional context

Please state your Python version: 3.11

A fix was released with https://github.com/PyCQA/isort/tree/5.11.5 - I suggest we update the pre-commit config accordingly.

@mj0nez mj0nez added bug Something isn't working Python Specific 🐍 a problem that is specific to this python implementation and not the bo4e data model labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Python Specific 🐍 a problem that is specific to this python implementation and not the bo4e data model
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant