Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable type-aware linting #345

Merged
merged 1 commit into from Dec 15, 2022
Merged

Enable type-aware linting #345

merged 1 commit into from Dec 15, 2022

Conversation

bmish
Copy link
Owner

@bmish bmish commented Dec 13, 2022 •
edited

https://typescript-eslint.io/linting/typed-linting/

Should not have any behavior changes.

Improve types in several places.

@bmish bmish added the internal label Dec 13, 2022
bmish
bmish commented Dec 14, 2022
View reviewed changes
lib/generator.ts
@@ -269,15 +269,18 @@ export async function generate(path: string, options?: GenerateOptions) {
);
}

for (const pathRuleListItem of Array.isArray(pathRuleList)
// eslint-disable-next-line unicorn/no-instanceof-array -- using Array.isArray() loses type information about the array.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly related:

@bmish bmish force-pushed the ts-type-aware-lint branch 3 times, most recently from 0bf5ac5 to 299ccb0 Compare December 15, 2022 00:11
@bmish bmish marked this pull request as ready for review December 15, 2022 00:21
@bmish bmish merged commit 1e1debc into main Dec 15, 2022
@bmish bmish deleted the ts-type-aware-lint branch December 15, 2022 00:37
@bmish bmish mentioned this pull request May 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bmish