Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid attempting to link to a third-party replacement rule for a deprecated rule #297

Closed
bmish opened this issue Nov 27, 2022 · 0 comments · Fixed by #367
Closed

Avoid attempting to link to a third-party replacement rule for a deprecated rule #297

bmish opened this issue Nov 27, 2022 · 0 comments · Fixed by #367
Labels
bug Something isn't working

Comments

@bmish
Copy link
Owner

bmish commented Nov 27, 2022

When a rule is deprecated and specifies a third-party rule as its replacement (meta.replacedBy: ['foo/some-external-rule']), we should avoid attempting to link to it as if it's one of our own rules, as this will result in a broken link. Since we won't know the correct path to it, we'll have to avoid linking to it for now.

Perhaps meta.replacedBy should allow specifying the URL to the replacement rule. This is related to jsx-eslint/eslint-plugin-react#3469 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant