Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji superscript can still be split onto a separate line #204

Closed
bmish opened this issue Nov 1, 2022 · 0 comments · Fixed by #205
Closed

Emoji superscript can still be split onto a separate line #204

bmish opened this issue Nov 1, 2022 · 0 comments · Fixed by #205
Labels
bug Something isn't working

Comments

@bmish
Copy link
Owner

bmish commented Nov 1, 2022

I partially fixed this in: #203

In this example, the column width is so narrow that it linebreaks both emojis from their superscripts.

Solutions that didn't work:

  • Turns out GitHub markdown filters out CSS styles so the previous solution doesn't work. There's also a GitHub pre-existing nowrap class but we can't add classes either.
  • Of the allowed HTML elements, none that I tested helped us avoid the linebreak. <wbr> did not help.
  • &nbsp; in various placements did not help. It might have been more helpful if we could do something like ☑️ ⌨️<sup>&nbsp;🚫</sup>, but GitHub converts all emojis to a <g-emoji> tag for compatibility which prevents this from working. <code> and <pre> prevent the conversion to <g-emoji> but add unwanted formatting.
  • There's no actual superscript version of an emoji character that might be more likely to stay attached to its base character, so I have to use the <sup> tag.
  • Using <div> around the emoji (or <br> in front) and 5 &nbsp; in header appears to work but causes unwanted vertical spacing in header cell. Could avoid this vertical spacing if we could prevent the header conversion to <g-emoji>.
  • Tried 0 and 1 superscript characters instead of <sup> with emojis but superscript still got detached

I may have to switch to separate columns for warn/off configs and avoid using superscripts in table cells due to the possibility of superscript detachment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant