Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't require ParitalEq to the Item of DedupBy #397

Merged
merged 1 commit into from Jan 14, 2020
Merged

don't require ParitalEq to the Item of DedupBy #397

merged 1 commit into from Jan 14, 2020

Conversation

KeenS
Copy link
Contributor

@KeenS KeenS commented Jan 10, 2020 •
edited

PartialEq is't needed because dedup_pred take its place.

@jswrenn
Copy link
Member

jswrenn commented Jan 14, 2020

Thanks!

bors r+

@jswrenn jswrenn added this to the next milestone Jan 14, 2020
bors bot added a commit that referenced this pull request Jan 14, 2020
@bors @phimuemue @KeenS
Merge #391 #397
43bbade 
391: Simplify `Clone` implementations r=jswrenn a=phimuemue

Use a macro `clone_fields`, similar to `debug_fmt_fields`.

I replaced existing implementations of `clone_fields` and simplified the macro's parameters.

397: don't require ParitalEq to the Item of DedupBy r=jswrenn a=KeenS

`PartialEq` is't needed because `dedup_pred` take its place.

Co-authored-by: philipp <descpl@yahoo.de>
Co-authored-by: κeen <3han5chou7@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 14, 2020

Build succeeded

@bors bors bot merged commit 31c3544 into rust-itertools:master Jan 14, 2020
@dependabot dependabot bot mentioned this pull request Mar 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KeenS @jswrenn