Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add derive(Clone) where possible #382

Merged
merged 1 commit into from Jan 1, 2020
Merged

Add derive(Clone) where possible #382

merged 1 commit into from Jan 1, 2020

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Nov 10, 2019

No description provided.

@andersk
Add derive(Clone) where possible
1e97bf2 
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@TomCrypto
Copy link

Would be great to have this merged, this PR is quite necessary when you have an iterator chain that eventually needs to be cloned (e.g. for .cycle()) but some itertools combinator in the chain fails to be Clone...

@phimuemue
Copy link
Member

Looks good to me. Maybe we can simplify the manual impls after merging this (e.g. via a macro similar to debug_fmt_fields).

@jswrenn
Copy link
Member

jswrenn commented Jan 1, 2020

Thanks!

bors r+

@jswrenn jswrenn added this to the next milestone Jan 1, 2020
bors bot added a commit that referenced this pull request Jan 1, 2020
@bors @andersk
Merge #382
505e0f4 
382: Add derive(Clone) where possible r=jswrenn a=andersk



Co-authored-by: Anders Kaseorg <andersk@mit.edu>
@bors
Copy link
Contributor

bors bot commented Jan 1, 2020

Build succeeded

And happy new year from bors! 🎉

@bors bors bot merged commit 1e97bf2 into rust-itertools:master Jan 1, 2020
@dependabot dependabot bot mentioned this pull request Mar 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andersk @TomCrypto @phimuemue @jswrenn