Use slice::iter instead of into_iter to avoid future breakage
#378
Conversation
`an_array.into_iter()` currently just works because of the autoref feature, which then calls `<[T] as IntoIterator>::into_iter`. But in the future, arrays will implement `IntoIterator`, too. In order to avoid problems in the future, the call is replaced by `iter()` which is shorter and more explicit.
|
bors r+ |
378: Use `slice::iter` instead of `into_iter` to avoid future breakage r=jswrenn a=LukasKalbertodt `an_array.into_iter()` currently just works because of the autoref feature, which then calls `<[T] as IntoIterator>::into_iter`. But in the future, arrays will implement `IntoIterator`, too. In order to avoid problems in the future, the call is replaced by `iter()` which is shorter and more explicit. A crater run showed that your crate is affected by a potential future change. See rust-lang/rust#65819 for more information. Co-authored-by: Lukas Kalbertodt <lukas.kalbertodt@gmail.com>
Build succeeded |
|
Not to be rushing anyone, but would it be possible to release this as 0.8.2? Lots of crates are depending on |
|
Done! Sorry for the delay. Since the affected code is part of a benchmark, would this breakage actually affect library users? |
This comment has been minimized.
This comment has been minimized.
|
Okay, I have understood the situation. Finally. My root regression analysis never actually checked how many regressions a particular root regression caused, but just sorted by reverse dependencies. I just adjusted the analysis to account for that (which I should have done already some time ago). And it turns out: no regressions are caused by Again, please excuse my hastily actions and that I asked you to release a new version without properly checking if it is worth anything. I'm very sorry and try to be more careful in the future! |
an_array.into_iter()currently just works because of the autoreffeature, which then calls
<[T] as IntoIterator>::into_iter. Butin the future, arrays will implement
IntoIterator, too. In orderto avoid problems in the future, the call is replaced by
iter()which is shorter and more explicit.
A crater run showed that your crate is affected by a potential future change. See rust-lang/rust#65819 for more information.