Add miri builder #218
Add miri builder #218
Conversation
|
Any idea about that failure? I'm running locally and it's okay so far, but miri is also up to 10GB memory after 13 minutes. Maybe CI went OOM? Anyway, as long as there's no real issue there, we should probably |
|
I think we're tripping over rust-lang/miri#1367, where the stacked borrow check is superlinear. We probably need to reduce the cycles for miri. I'll switch some of these expensive tests to that. One interesting thing to note though that for map::tests::insert_2 uses about 2.2GB, but swapping in a HashMap, it only uses 338MB. |
|
I pushed up a new version that uses lower limits when run inside miri. Hopefully that'll use less memory and run faster. |
This adds a builder to run `cargo miri` in order to check for certain classes of undefined behavior. One thing to note is that we've had to parameterize a number of tests to use a smaller cycle count under miri. This is because miri's stacked borrows checker is superlinear: rust-lang/miri#1367 This can cause the miri builder to run out of memory. To avoid this, we reduce the cycle counts for a few tests that are particularly expensive when we're running inside miri.
|
Thanks! The new 4m miri CI time is totally reasonable. |
This adds a builder to run
cargo miriin order to check for certain classes of undefined behavior.