Implemented Binary and Display traits for FixedBitSet. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
reviewed
Apr 15, 2020
src/lib.rs
Outdated
| }; | ||
|
|
||
| for block in self.data.iter().rev() { | ||
| display_data = display_data.add(&format!("{:b}", block)); |
There was a problem hiding this comment.
nice. I'd suggest that we just write this piece by piece instead of creating an intermediate String.
bluss
reviewed
Apr 15, 2020
src/lib.rs
Outdated
| @@ -356,6 +360,32 @@ impl FixedBitSet | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "std")] | |||
There was a problem hiding this comment.
These don't depend on the std feature and will work fine with core, in fact. That's just a smaller thing.
There was a problem hiding this comment.
I should remove it though if it is true. On it.
|
Looks good |
|
Cool, thanks! Let's be open to tweaks to the format in the future. Maybe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing some implementation for #34. Need feedback.