Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider #[track_caller] on functions that panic #212

Closed
joshtriplett opened this issue Jan 29, 2022 · 3 comments
Closed

Consider #[track_caller] on functions that panic #212

joshtriplett opened this issue Jan 29, 2022 · 3 comments

Comments

@joshtriplett
Copy link

For functions that panic, such as extend, please consider using #[track_caller], to provide more meaningful location information for debugging such panics.

(This report inspired by debugging an ArrayVec panic inside rust-lang/rust CI.)

@bluss
Copy link
Owner

bluss commented Jan 29, 2022

Needs knowledge about the performance impact - probably not a great concern for extend, but for other hotter methods.

@joshtriplett
Copy link
Author

@bluss Absolutely. I filed this issue rather than submitting a PR, because this would absolutely require checking the performance impact.

@bluss
Copy link
Owner

bluss commented Jun 12, 2023

Fixed by #236

@bluss bluss closed this as completed Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants