Mirror optimization of std::Vec::retain (rust-lang/rust#81126) #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
reviewed
Feb 21, 2021
bluss
reviewed
Feb 21, 2021
niklasf
force-pushed
the
optimize-retain
branch
from
200f0a3
to
b9e755c
Compare
|
Ah, indeed. I was confused how this could be fine in std and not here, but the closure in std takes a shared reference. |
|
I pushed a fix on master to the doc build issue in CI, and we can merge this after it runs ok again |
bluss
approved these changes
Feb 22, 2021
Co-authored-by: bluss <bluss@users.noreply.github.com>
|
Rebased and updated syntactically for const generics |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the optimization from rust-lang/rust#81126 applies also to ArrayVec.