Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to append another array #103

Open
jD91mZM2 opened this issue Sep 22, 2018 · 1 comment
Open

Add a way to append another array #103

jD91mZM2 opened this issue Sep 22, 2018 · 1 comment
Labels
enhancement help wanted

Comments

@jD91mZM2
Copy link

I'm not sure, but I suspect having an append function that consumes another arrayvec and ptr::copys over all elements at once would be faster than using extending an iterator which ptr::writes per-item.
@bluss
Copy link
Owner

bluss commented Nov 28, 2018 •
edited

Ideally extend shouldn't ptr::write per item, it should optimize better than that, but I suspect the IntoIter implementation is putting limits on how well that can be done.

PR welcome, please include tests.

tylerhawkes pushed a commit to jmc718/arrayvec that referenced this issue Feb 12, 2020
Added append and try_append with tests to implement bluss#103
b97c7ba
@jmc718 jmc718 mentioned this issue Feb 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bluss @jD91mZM2