Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Movable also a Readable and add a separate Protocol that can set but not read #1721

Open
noemifrisina opened this issue Apr 17, 2024 · 0 comments

Comments

@noemifrisina
Copy link

Current Behavior

The Movable protocol is used to describe motors, which in 99% of the use cases also need a read method.

Possible Solution

  • Have Movable inherit from Readable and use this in the plans/plan_stubs
  • Make a new Settable protocol which has set but not read
  • Use Settable in the RunEngine code

Context

Adding type hints in #1712 highlighted the fact that the definition of Movable does not include a read method, which is required by some plans which may be used on motors, eg. bps.trigger_and_read as used in bps.one_1d_step

Small side note: in #1712 code showing this behaviour has been temporarily marked with #type: ignore to get the CI tests to pass.

noemifrisina added a commit to noemifrisina/bluesky that referenced this issue Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant